Refine VCS URL install error message wording in Transaction.add_requirement - #278
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/pyodide/micropip/sessions/7f9aac28-3469-452c-8eed-1637470589ce Co-authored-by: ryanking13 <24893111+ryanking13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error message formatting for VCS URLs
Refine VCS URL install error message wording in May 20, 2026
Transaction.add_requirement
Member
|
@copilot also update the PR number in the changelog |
Agent-Logs-Url: https://github.com/pyodide/micropip/sessions/105b7d74-8c93-40c1-88b2-4b092d0fc14d Co-authored-by: ryanking13 <24893111+ryanking13@users.noreply.github.com>
Contributor
Author
agriyakhetarpal
approved these changes
May 20, 2026
Member
|
I ran the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #277: one review nit remained on the VCS-URL error text in
Transaction.add_requirement. This updates the message formatting/wording to match the requested phrasing without changing behavior.Error message wording (follow-up review nit)
ValueErrorguidance for VCS URLs inmicropip/transaction.py:_looks_like_vcs_url) and control flow unchanged.Test alignment
tests/test_transaction.pyto assert the revised guidance sentence, so expected text stays synchronized with the user-facing error.Original prompt
This pull request was created from Copilot chat.